[Fix][Connecotr-V2] Fix paimon dynamic bucket tale in primary key is not first #7728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dailai |
dailai
reviewed
Sep 24, 2024
...on/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/catalog/PaimonCatalog.java
Show resolved
Hide resolved
dailai
reviewed
Sep 24, 2024
...on/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/catalog/PaimonCatalog.java
Outdated
Show resolved
Hide resolved
dailai
reviewed
Sep 24, 2024
.../java/org/apache/seatunnel/connectors/seatunnel/paimon/sink/bucket/PaimonBucketAssigner.java
Show resolved
Hide resolved
dailai
reviewed
Sep 24, 2024
.../java/org/apache/seatunnel/connectors/seatunnel/paimon/sink/bucket/PaimonBucketAssigner.java
Outdated
Show resolved
Hide resolved
hawk9821
force-pushed
the
paimon_bucket
branch
3 times, most recently
from
c74d040 to
bcca704
Compare
Hisoka-X
changed the title
Hisoka-X
changed the title
hawk9821
force-pushed
the
paimon_bucket
branch
from
bb3e2fc to
9737e78
Compare
dailai
reviewed
Sep 25, 2024
...on/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/catalog/PaimonCatalog.java
Show resolved
Hide resolved
dailai
reviewed
Sep 25, 2024
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/config/PaimonSinkConfig.java
Show resolved
Hide resolved
hawk9821
force-pushed
the
paimon_bucket
branch
2 times, most recently
from
463ea30 to
73addf6
Compare
hawk9821
force-pushed
the
paimon_bucket
branch
from
73addf6 to
426c19d
Compare
dailai
approved these changes
Sep 25, 2024
Hisoka-X
reviewed
Sep 25, 2024
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/config/PaimonSinkConfig.java
Show resolved
Hide resolved
Hisoka-X
approved these changes
Sep 26, 2024
hailin0
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Dynamic bucket allocation did not take into account that the primary key was not in the first place, resulting in an error when executing the loadBucketIndex method in the initialization of the PaimonBucketAssigner class . This pr fixed the problem
Does this PR introduce any user-facing change?
How was this patch tested?
PaimonSinkDynamicBucketIT#primaryFullTypeAndLoadData
Check list
New License Guide
release-note.