[Fix][Connector-V2] Fix kafka format_error_handle_way not work
#7838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Hisoka-X
commented
Oct 16, 2024
| @@ -30,7 +30,10 @@ public final class Handover<T> implements Closeable { | |||
| new LinkedBlockingQueue<>(DEFAULT_QUEUE_SIZE); | |||
| private Throwable error; | |||
|
|
|||
| public boolean isEmpty() { | |||
| public boolean isEmpty() throws Exception { | |||
There was a problem hiding this comment.
Fix Spark will finished even read data failed when read first row.
hailin0
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Before this PR, the test case of format_error_handle_way not work right. It produce json format record and parse it by json format. It will never face format error situtation. This PR make sure the
format_error_handle_waywork right.Does this PR introduce any user-facing change?
no
How was this patch tested?
update test case.
Check list
New License Guide
release-note.