-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] [connector-milvus] update milvus connector to support dynamic schema, failed retry, etc. #7885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nianliuu
force-pushed
the
connector-milvus
branch
3 times, most recently
from
October 22, 2024 07:54
33ec252
to
f82729e
Compare
corgy-w
reviewed
Oct 22, 2024
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/BasicType.java
Outdated
Show resolved
Hide resolved
Hisoka-X
reviewed
Oct 22, 2024
...r-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/sink/MilvusSink.java
Outdated
Show resolved
Hide resolved
...r-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/sink/MilvusSink.java
Outdated
Show resolved
Hide resolved
nianliuu
force-pushed
the
connector-milvus
branch
3 times, most recently
from
October 23, 2024 03:56
d933aed
to
ee37d0e
Compare
Hisoka-X
reviewed
Oct 23, 2024
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java
Outdated
Show resolved
Hide resolved
nianliuu
force-pushed
the
connector-milvus
branch
6 times, most recently
from
October 24, 2024 06:03
d618271
to
54596ca
Compare
nianliuu
force-pushed
the
connector-milvus
branch
from
October 24, 2024 06:05
54596ca
to
f10874e
Compare
Hisoka-X
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if ci passes. Thanks @nianliuu !
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java
Show resolved
Hide resolved
Hisoka-X
previously approved these changes
Oct 24, 2024
nianliuu
force-pushed
the
connector-milvus
branch
from
October 24, 2024 10:03
f10874e
to
624d478
Compare
nianliuu
force-pushed
the
connector-milvus
branch
from
October 24, 2024 10:07
624d478
to
b420842
Compare
Hisoka-X
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
hailin0
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
In this PR, we updated milvus connector to better support vector data with following improvement:
Does this PR introduce any user-facing change?
No
How was this patch tested?
tested with real data to migrate data from milvus to milvus
Check list
New License Guide
release-note
.