Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Doc] Add some connector icons #7944

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

zhangshenghang
Copy link
Member

Purpose of this pull request

Add some connector icons

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@zhangshenghang zhangshenghang marked this pull request as ready for review October 31, 2024 02:24
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhangshenghang

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g.
Hdfs文件.svg
Apache Iceberg.svg

Should it contain spaces and Chinese characters?

cc @Hisoka-X

@Hisoka-X
Copy link
Member

e.g. Hdfs文件.svg Apache Iceberg.svg

Should it contain spaces and Chinese characters?

cc @Hisoka-X

Yep, the current logic is use markdown header name to mapping icon file. So the header name is contains chinese, the icon file should contains it too.
image

@liugddx liugddx merged commit cb9c257 into apache:dev Oct 31, 2024
7 checks passed
@hailin0
Copy link
Member

hailin0 commented Oct 31, 2024

e.g. Hdfs文件.svg Apache Iceberg.svg

Should it contain spaces and Chinese characters?

cc @Hisoka-X

#7954

@zhangshenghang zhangshenghang deleted the doc-add-icon branch November 13, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants