Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] fix exceptions caused by operator priority in connector-clickhouse when using sharding_key #8162

Merged
merged 9 commits into from
Jan 7, 2025
Merged

[hotfix] fix exceptions caused by operator priority in connector-clickhouse when using sharding_key #8162

merged 9 commits into from
Jan 7, 2025

Conversation

supernovaYe
Copy link
Contributor

Purpose of this pull request

fix of #8161

Does this PR introduce any user-facing change?

no

How was this patch tested?

tested locally using over 10000 data points and obtained the maximum and minimum values of the modulus after hashing

Check list

@supernovaYe
Fix exceptions caused by operator priority
7ebdb15 
&Operator priority is lower than%, resulting in the program not executing as expected
@sunxiaojian
Copy link
Contributor

Run mvn spotless:apply to fix ci

@sunxiaojian
Copy link
Contributor

Run mvn spotless:apply to fix ci

@supernovaYe please fix ci

@Hisoka-X
Copy link
Member

Hisoka-X commented Dec 3, 2024

Could you mind add an unit test for this method? https://github.com/apache/seatunnel/pull/8162/files#diff-f4bb0831ff0d565061930b5e556ec8836783b1ba1420515d29d4a216aa37ba96R106 Thanks.

@supernovaYe
Copy link
Contributor Author

Sure, I will fix ci and complete an unit tests after I finish my work

yeside and others added 6 commits January 6, 2025 17:29
Add unit test
ea88f87
@supernovaYe
Merge branch 'apache:dev' into dev
8b43cbf
@supernovaYe
Merge branch 'dev' of https://github.com/supernovaYe/incubator-seatunnel
db56bee 
 into dev

# Conflicts:
#	seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/client/ShardRouter.java
@supernovaYe
Add license header
5d1319e
@supernovaYe
Add unit test
2c62a60
@supernovaYe
Fix ci
0ba414a
Hisoka-X
Hisoka-X reviewed Jan 7, 2025
View reviewed changes
...ouse/src/test/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/ShardRouterTest.java Outdated
Comment on lines 47 to 48
@Test
public void test() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case useless. Please remove it.

...ouse/src/test/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/ShardRouterTest.java Outdated
}

@Test
public void test2() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public void test2() {
public void testWithShardRouterGetShardRight() {

@Hisoka-X Hisoka-X added the First-time contributor First-time contributor label Jan 7, 2025
@hailin0 hailin0 merged commit 5560e3d into apache:dev Jan 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@hailin0 hailin0 hailin0 approved these changes

Assignees
No one assigned
Labels
approved clickhouse connectors-v2 First-time contributor First-time contributor reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@supernovaYe @sunxiaojian @Hisoka-X @hailin0