Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Doc] Improve the connector-v2 develop doc #8190

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

YOMO-Lee
Copy link
Contributor

@YOMO-Lee YOMO-Lee commented Dec 2, 2024

Supplementary explanations have been provided for the methods and classes that must be implemented during the source development process

…che#7959

Supplementary explanations have been provided for the methods and classes that must be implemented during the source development process
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YOMO-Lee . This PR looks great.

Comment on lines 59 to 63
6.There are several classes that must be implemented on the source side, namely {connector name} Source, {connector name} SourceFactory, {connector name} SourceReader. Please refer to other connectors for details

7.{Connector Name} SourceFactory needs to be annotated with the **@AutoService (Factory.class)** annotation on the class name, and in addition to the required methods, an additional 'creatSource' method needs to be rewritten

8.{Connector Name} Source needs to override the getProducedCatalogTables method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add sink too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I have only done source development and not sink development, so I am not sure if what I am writing is correct

liunaijie
liunaijie previously approved these changes Dec 3, 2024
hailin0
hailin0 previously approved these changes Dec 3, 2024
@YOMO-Lee YOMO-Lee dismissed stale reviews from hailin0 and liunaijie via 5cffa18 December 3, 2024 02:00
@Hisoka-X Hisoka-X changed the title [hotfix] [DOC] Fix missing areas in the development documentation #7959 [Improve][Doc] Improve the connector-v2 develop doc Dec 3, 2024
@YOMO-Lee
Copy link
Contributor Author

YOMO-Lee commented Dec 3, 2024

@hailin0 @liunaijie please review again ,thx

@dailai dailai merged commit 8e8c534 into apache:dev Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants