Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2[Doris]Support sink ddl #8250

Merged
merged 11 commits into from
Dec 19, 2024

Conversation

deng-jeffer
Copy link
Contributor

@deng-jeffer deng-jeffer commented Dec 9, 2024

Purpose of this pull request

close #8115

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to starrocks

#8082

@davidzollo davidzollo added the First-time contributor First-time contributor label Dec 9, 2024
@deng-jeffer
Copy link
Contributor Author

Please refer to starrocks

#8082

i have fix some bug, please CR again

@hailin0
Copy link
Member

hailin0 commented Dec 16, 2024

Please check ci error

dailai
dailai previously approved these changes Dec 19, 2024
Copy link
Contributor

@dailai dailai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/en/concept/schema-evolution.md Outdated Show resolved Hide resolved
docs/zh/concept/schema-evolution.md Outdated Show resolved Hide resolved
@Hisoka-X Hisoka-X merged commit ecd8269 into apache:dev Dec 19, 2024
5 checks passed
import org.apache.seatunnel.common.exception.SeaTunnelErrorCode;
import org.apache.seatunnel.common.exception.SeaTunnelRuntimeException;

public class DorisSchemaChangeException extends SeaTunnelRuntimeException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no need to add a new class, suggestion rename DorisConnectorException to DorisException

case STRING:
case BIGINT:
case INT:
case TIMESTAMP:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still supported TIMESTAMP in the case of oracle-cdc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is doris sink , nothing to do with oracle

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mysql is compatible with doris , your case source is mysql-cdc, bug source is oracle-cdc, will it still work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default type supported by doris, if oracle unsupported ,it will not Include 'TIMESTAMP'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Doris] Support sink ddl
6 participants