-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-559] Make the flink example work #1420
Conversation
@docete Sorry, the example projects are not included in the parent pom on purpose. They are not considered as |
@jiayuasu IMO it should be included in the parent pom if it is placed in the same repo. Otherwise, it will not be well maintained. BTW, we should implement our use cases as the formal demonstration. What do you think? |
The purpose of the example projects is to demo that you can build applications on top of the released version of Sedona. This is also useful for us to discover dependency bugs which cannot be discovered when bundled together with the parent pom. We also have CI/CD to test the correctness of the example projects. |
OK, I will unbundle the example projects and fix the build/run issues. |
Check the ci/cd issues |
We could but we don't have to. What is your preference? |
Let it consistent with SEDONA parent to keep it up to date with every release. |
sounds good! |
updated the github ci/cd script. |
* [hotfix] Enable scalastyle config * [SEDONA-559] Make the flink example project work * [hotfix] unbundle the example projects * [hotfix] fix example version in github ci/cd pipeline * [hotfix] Remove slf4j-api 1.7.36 from example parent because spark need slf4j-api 2.x * [hotfix] remove parent pom
The sedona examples project is not managed by parent pom file.
It should be a submodule of the parent project and the flink example should work in IDE.
This PR fix this.
What changes were proposed in this PR?
How was this patch tested?