Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] add canonical links to docs #1735

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

MrPowers
Copy link
Contributor

Work in progress!

Fixes #1730.

Opened up an issue with mike cause it's potentially an issue on their end: jimporter/mike#235

@MrPowers
Copy link
Contributor Author

I added the site_url so I think this should be working now, but someone should double check!

I only think this will fix the docs on a go-forward basis. We'd need to roll out some sort of hotfix if we wanted to add canonical links to all the existing docs sites.

@jiayuasu
Copy link
Member

jiayuasu commented Jan 2, 2025

@MrPowers is this ready to go?

@MrPowers MrPowers changed the title [WIP] add canonical links to docs add canonical links to docs Jan 3, 2025
@jiayuasu jiayuasu changed the title add canonical links to docs [DOCS] add canonical links to docs Jan 7, 2025
@jiayuasu
Copy link
Member

jiayuasu commented Jan 7, 2025

I will merge this PR and let's see how it goes. If it does not work, we can try to fix again.

@jiayuasu jiayuasu merged commit 5dd127a into apache:master Jan 7, 2025
3 checks passed
jiayuasu pushed a commit that referenced this pull request Jan 7, 2025
* [WIP] add canonical links to docs

* add site_url for docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add canonical links to the documentation pages
2 participants