-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues #539 update the dependency list and add the corresponding license #542
Conversation
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
+ Coverage 57.85% 57.91% +0.06%
==========================================
Files 185 185
Lines 14823 14823
==========================================
+ Hits 8576 8585 +9
+ Misses 5644 5637 -7
+ Partials 603 601 -2
Continue to review full report at Codecov.
|
please update the main LICENSE file as well https://github.com/apache/servicecomb-service-center/blob/master/scripts/release/LICENSE |
I see there are few dependency listed in go.mod file which is not added in LICENSE file |
@asifdxtreme @little-cui Added Please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles
, where you replaceSCB-XXX
with the appropriate JIRA issue.go build
go test
go fmt
go vet
to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.