Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues #539 update the dependency list and add the corresponding license #542

Merged
merged 2 commits into from
Mar 28, 2019

Conversation

ChinX
Copy link
Contributor

@ChinX ChinX commented Mar 27, 2019

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@little-cui little-cui self-requested a review March 27, 2019 03:33
@little-cui
Copy link
Member

#539

@codecov-io
Copy link

Codecov Report

Merging #542 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
+ Coverage   57.85%   57.91%   +0.06%     
==========================================
  Files         185      185              
  Lines       14823    14823              
==========================================
+ Hits         8576     8585       +9     
+ Misses       5644     5637       -7     
+ Partials      603      601       -2
Impacted Files Coverage Δ
server/notify/websocket.go 80.57% <0%> (-0.58%) ⬇️
server/plugin/pkg/registry/etcd/etcd.go 86.48% <0%> (+0.18%) ⬆️
server/broker/util.go 53.47% <0%> (+0.26%) ⬆️
pkg/tlsutil/tlsutil.go 74.52% <0%> (+0.94%) ⬆️
server/notify/listwatcher.go 79.16% <0%> (+9.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a60d63...587ee4c. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 27, 2019

Coverage Status

Coverage decreased (-0.2%) to 60.088% when pulling 80b2527 on ChinX:master into 2a60d63 on apache:master.

@asifdxtreme
Copy link
Member

@asifdxtreme
Copy link
Member

I see there are few dependency listed in go.mod file which is not added in LICENSE file

@ChinX
Copy link
Contributor Author

ChinX commented Mar 27, 2019

please update the main LICENSE file as well https://github.com/apache/servicecomb-service-center/blob/master/scripts/release/LICENSE

@asifdxtreme @little-cui Added Please check

Copy link
Member

@little-cui little-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants