Fix bugs of training #667
Merged
Fix bugs of training #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
XJDKC
commented
Apr 8, 2020
XJDKC
commented
- Fix bugs of buffering Mult.
- Can train ResNet50 with batch size of 64 now.
|
There is another commit to be pushed. |
nudles
reviewed
Apr 8, 2020
| @@ -161,6 +161,9 @@ Tensor Resize(const Tensor &in, const Shape &shape) { | |||
|
|
|||
| // return new tensor | |||
| Tensor Tensor::AsType(const DataType type) { | |||
| CHECK(block() && block()->initialized() == true) | |||
| << "the data of the tensor needs be initialized before casting to " | |||
There was a problem hiding this comment.
this cannot fix the error. need to update the test case to reverse the two lines.
There was a problem hiding this comment.
There seem to be many such cases in unit testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.