Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish release doc #106

Merged
merged 1 commit into from
May 16, 2022
Merged

Polish release doc #106

merged 1 commit into from
May 16, 2022

Conversation

fgksgf
Copy link
Member

@fgksgf fgksgf commented May 16, 2022

No description provided.

@fgksgf fgksgf added the chore label May 16, 2022
@fgksgf fgksgf added this to the 0.4.0 milestone May 16, 2022
@fgksgf fgksgf requested a review from kezhenxu94 May 16, 2022 08:42
@@ -76,6 +76,10 @@ docker:
docker-push:
docker push $(HUB)/$(PROJECT):$(VERSION)

.PHONY: docker-release
docker-release: docker docker-push
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to consider (seriously) providing multi-architecture Docker images 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, next pr.

@kezhenxu94 kezhenxu94 merged commit 7db9a79 into main May 16, 2022
@kezhenxu94 kezhenxu94 deleted the polish-release branch May 16, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants