Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify some of dual licenses and skip built-in packages' licenses #18

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Identify some of dual licenses and skip built-in packages' licenses #18

merged 2 commits into from
Jan 8, 2021

Conversation

kezhenxu94
Copy link
Member

@kezhenxu94 kezhenxu94 commented Jan 8, 2021 •
edited
Loading

This PR adds a pattern to identify dual-license and skip resolving built-in package's licenses

@kezhenxu94 kezhenxu94 added the enhancement New feature or request label Jan 8, 2021
@kezhenxu94 kezhenxu94 added this to the 0.1.0 milestone Jan 8, 2021
@kezhenxu94 kezhenxu94 requested a review from wu-sheng January 8, 2021 08:43
wu-sheng
wu-sheng approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember you mentioned, license check should be 0.2.0 scope. Are we going to add more into 0.1.0?

@kezhenxu94 kezhenxu94 merged commit 13ff130 into main Jan 8, 2021
@kezhenxu94 kezhenxu94 deleted the dual-license branch January 8, 2021 09:36
@kezhenxu94
Copy link
Member Author

Just a minor polish, we won't highlight dependencies' license check in 0.1.0.

BTW, hopefully I can start the release process within this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kezhenxu94 @wu-sheng