-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for resolving npm dependencies' licenses #48
Conversation
zooltd
commented
Jul 23, 2021
- Parse the project package.json file to gather the required packages
- Run command 'npm install' to install or update the required node packages (can skip)
- Walk through each package's root directory to resolve licenses
- STEP 1: Try to find and parse the package.json file to capture the license field
- STEP 2: Try to find the license file to identify the license
You should update the doc to show how to use this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very good start point to resolve dependencies’ licenses in NPM projects.
This PR only resolves the direct dependencies’ licenses, will you continue to resolve their transitive dependencies in next PR?
Glad to take it. Also, I'm planning to resolve dev-dependencies' licenses. |
Notice, dev-dependency is not binary level or source code level dependency. |
Dev-tool should not include commercial or unknown licenses. But even GPL and AGPL are fine to use, that is what I mean different. |
Got it. I will work on this feature in next PR. |