Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add comment type to cython declaration #62

Merged
merged 3 commits into from
Aug 25, 2021
Merged

add comment type to cython declaration #62

merged 3 commits into from
Aug 25, 2021

Conversation

keiranmraine
Copy link
Contributor

@keiranmraine keiranmraine commented Aug 25, 2021 •
edited
Loading

Relates to #7552

Modified:

  • assets/languages.yaml
    • Added comment_style_id to cython section
  • README.md
    • Corrected link/description indicating languages.yaml instead of styles.yaml
    • Some whitespace trimming occurred (sorry)

Added test files for */pyx:

test/testdata/include_test/with_license/testcase.pyx
test/testdata/include_test/without_license/testcase.pyx

Confirmed working via local docker build and testing against file indicated in apache/skywalking#7552

@wu-sheng wu-sheng requested review from kezhenxu94 and fgksgf August 25, 2021 09:23
@keiranmraine keiranmraine mentioned this pull request Aug 25, 2021
Closed
4 tasks
@kezhenxu94 kezhenxu94 added the enhancement New feature or request label Aug 25, 2021
@kezhenxu94 kezhenxu94 added this to the 0.2.0 milestone Aug 25, 2021
kezhenxu94
kezhenxu94 approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @keiranmraine very much 🙇🏻

@kezhenxu94 kezhenxu94 merged commit 1e5ec5b into apache:main Aug 25, 2021
@keiranmraine keiranmraine deleted the feature/addCython branch August 26, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@fgksgf fgksgf Awaiting requested review from fgksgf

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@keiranmraine @kezhenxu94