Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve absolute path in .gitignore to relative path #67

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Resolve absolute path in .gitignore to relative path #67

merged 1 commit into from
Sep 8, 2021

Conversation

kezhenxu94
Copy link
Member

@kezhenxu94 kezhenxu94 added the bug Something isn't working label Sep 8, 2021
@kezhenxu94 kezhenxu94 added this to the 0.2.0 milestone Sep 8, 2021
@kezhenxu94 kezhenxu94 requested a review from wu-sheng September 8, 2021 06:00
@kezhenxu94
Copy link
Member Author

Trimming the leading / should fix the bug, whatever/whatever/bin/whatever.go will NOT be ignored, this is the same behavior as .gitignore

@wu-sheng wu-sheng merged commit 62071db into main Sep 8, 2021
@wu-sheng wu-sheng deleted the gitignore branch September 8, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

[Eyes] Absolute path resolution bug in git ignore and check escape
2 participants
@kezhenxu94 @wu-sheng