Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a netty-4.1.x plugin to trace http #625

Merged
merged 87 commits into from
Oct 29, 2023
Merged

Add a netty-4.1.x plugin to trace http #625

merged 87 commits into from
Oct 29, 2023

Conversation

peachisai
Copy link
Contributor

Add an agent plugin to support

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wu-sheng
Copy link
Member

Before any review, I think we need a clearance from you, what is netty plugin.
Netty is a widely used TCP level framework. So in theory, there isn't a general solution to fit it, as TCP doesn't have a header to inject.

@peachisai
Copy link
Contributor Author

Before any review, I think we need a clearance from you, what is netty plugin. Netty is a widely used TCP level framework. So in theory, there isn't a general solution to fit it, as TCP doesn't have a header to inject.

Yes, it is only tracing HTTP now. If I have rest of the time, I will provide other protocol tracings. So, is it acceptable?

@wu-sheng
Copy link
Member

Then you should be clear for all relative codes and docs.
This is only netty-http

@peachisai
Copy link
Contributor Author

Then you should be clear for all relative codes and docs. This is only netty-http

ok i will change those

Comment on lines +42 to +46
- segmentId: not null
spans:
- operationName: Netty-http:/user
parentSpanId: -1
spanId: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to double check, the reason that this exit span doesn't have a parent entry span, is this RPC client called in async?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to #625 (comment), there is a parent entry span expected. If this is caused by async, you should consider connecting the parent entry and this exit span, through application toolkit lib or some mechanism you prefer.

@wu-sheng
Copy link
Member

@peachisai Any feedback?

@peachisai
Copy link
Contributor Author

@peachisai Any feedback?

This week i am a little busy,i will provide feedback as soon as possible.

@wu-sheng
Copy link
Member

So, the previous codes miss the way connecting between the main thread and netty HTTP sender channel?

@peachisai
Copy link
Contributor Author

@peachisai Any feedback?

done

@wu-sheng wu-sheng added this to the 9.1.0 milestone Oct 29, 2023
@peachisai
Copy link
Contributor Author

So, the previous codes miss the way connecting between the main thread and netty HTTP sender channel?

Yes

wu-sheng
wu-sheng previously approved these changes Oct 29, 2023
@wu-sheng wu-sheng merged commit 0b80f3d into apache:main Oct 29, 2023
181 checks passed
@peachisai peachisai deleted the uat branch October 30, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants