-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a netty-4.1.x plugin to trace http #625
Conversation
� Conflicts: � apm-sniffer/apm-sdk-plugin/pom.xml
� Conflicts: � apm-sniffer/config/agent.config
# Conflicts: # CHANGES.md
Before any review, I think we need a clearance from you, what is netty plugin. |
Yes, it is only tracing HTTP now. If I have rest of the time, I will provide other protocol tracings. So, is it acceptable? |
Then you should be clear for all relative codes and docs. |
ok i will change those |
- segmentId: not null | ||
spans: | ||
- operationName: Netty-http:/user | ||
parentSpanId: -1 | ||
spanId: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to double check, the reason that this exit span doesn't have a parent entry span, is this RPC client called in async?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to #625 (comment), there is a parent entry span expected. If this is caused by async, you should consider connecting the parent entry and this exit span, through application toolkit lib or some mechanism you prefer.
@peachisai Any feedback? |
This week i am a little busy,i will provide feedback as soon as possible. |
So, the previous codes miss the way connecting between the main thread and netty HTTP sender channel? |
done |
Yes |
Add an agent plugin to support
CHANGES
log.