Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support across thread tracing for SOFA-RPC #675

Merged
merged 10 commits into from
Mar 25, 2024
Merged

Support across thread tracing for SOFA-RPC #675

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7358873
Add across thread solution for sofarpc
OrezzerO Mar 20, 2024
7d9e11d
Change CHANGES.md
OrezzerO Mar 20, 2024
9393f88
Add sofarpc test casees
OrezzerO Mar 21, 2024
0840582
reformat code
OrezzerO Mar 21, 2024
40d7b27
Simplify sofarpc-scenario test case
OrezzerO Mar 21, 2024
8680f82
Add callback wrapper to ensure contextSnapshot is one time used.
OrezzerO Mar 24, 2024
bb384e4
Apply suggestions from code review
wu-sheng Mar 24, 2024
5cccf8f
Add lombok annotations for getter methods.
OrezzerO Mar 25, 2024
05b4357
Apply suggestions from code review
wu-sheng Mar 25, 2024
49ffb3f
Add lombok import statement
OrezzerO Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions ...-plugin/src/main/java/org/apache/skywalking/apm/plugin/sofarpc/InvokeCallbackWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,16 @@

import com.alipay.remoting.InvokeCallback;
import java.util.concurrent.Executor;
import lombok.Getter;
import org.apache.skywalking.apm.agent.core.context.ContextManager;
import org.apache.skywalking.apm.agent.core.context.ContextSnapshot;
import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;

public class InvokeCallbackWrapper implements InvokeCallback {

@Getter
private ContextSnapshot contextSnapshot;
@Getter
private final InvokeCallback invokeCallback;

public InvokeCallbackWrapper(InvokeCallback invokeCallback) {
Expand Down Expand Up @@ -81,12 +84,4 @@ public void onException(final Throwable throwable) {
public Executor getExecutor() {
return invokeCallback.getExecutor();
}

protected ContextSnapshot getContextSnapshot() {
return contextSnapshot;
}

protected InvokeCallback getInvokeCallback() {
return invokeCallback;
}
}