Add Caffeine plugin as optional #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As you are adding a new component ID, please add it to the main repo and reserve it. |
wu-sheng
reviewed
Dec 28, 2024
wu-sheng
reviewed
Dec 28, 2024
...x-plugin/src/main/java/org/apache/skywalking/apm/plugin/caffeine/v3/CaffeineInterceptor.java
Outdated
Show resolved
Hide resolved
wu-sheng
reviewed
Dec 28, 2024
...src/main/java/org/apache/skywalking/apm/testcase/caffeine/controller/CaffeineController.java
Outdated
Show resolved
Hide resolved
wu-sheng
reviewed
Dec 28, 2024
| final Class<?>[] argumentsTypes, | ||
| final MethodInterceptResult result) throws Throwable { | ||
| AbstractSpan span = generateSpanInfo(method.getName()); | ||
| if (allArguments != null && allArguments.length > 0) { |
There was a problem hiding this comment.
Is this necessary? In which case, allArguments is unexpected?
There was a problem hiding this comment.
I prefer to add judgment, not sure all inputs meet the expectations before this function is processed by upstream.
wu-sheng
previously approved these changes
Dec 28, 2024
wu-sheng
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGESlog.