-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new v2 protocol and make concept consistently #1937
Conversation
I have passed my local test. @ascrutae wait for your tests to recheck. |
I have known @JaredTan95 you are building and publishing a series of videos for SkyWalking, even for v6. Very appreciate for your contributions. I want to head you up, this PR is important before 6.0.0-GA, it makes the concepts consistently in core codes and UI. New protocols are provided, old(version 1) is still supported. |
I just finish the v2 protocol document in this PR. Text is here, links are not working in comment, but right in doc md. Trace Data Protocol v2Trace Data Protocol describes the data format between SkyWalking agent/sniffer and backend. OverviewTrace data protocol is defined and provided in gRPC format. For each agent/SDK, it needs to register service id and service instance id before reporting any kind of trace Step 1. Do registerRegister service takes charge of
For register, the most important notice is that, the process is expected as async in backend, so, the return could be NULL. Because batch is supported, even for most language agent/SDK, no scenario to do batch register. We suggest to check the Step 2. Send trace and metricAfter you have trace id and trace instance id, you could send traces and metric. Now we
For trace format, there are some notices
Step 3. Keep alive.
|
Here is the test report and validate logs |
@ascrutae Could you recheck the new test repo and cases to find out why 145 cases fail. I guess my changes could not make this happens. Correct me if I do a wrong assumption. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
All new protocols, v2, are available in https://github.com/apache/incubator-skywalking-data-collect-protocol/tree/005879debb510206a9de4f3b94d4132ec8ff2179
All new services are in
language-agent-v2
andregister
. gRPC is provided, no Restful yet.@ascrutae I need you to make autotests ready for all these as soon as possible. Please make the high priority of this task.
@liuhaoyang @ascrutae This should be supported in new .NET release and Nodejs release