Support custom log4j2 config from user-provided ConfigMap #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelabdude
commented
Jan 28, 2021
|
Now with docs! ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #192
SolrCloud controller now looks for the presence of a
log4j2.xmlkey in theinstance.Spec.CustomSolrKubeOptions.ConfigMapOptions.ProvidedConfigMapThe only tricky aspect of this PR is we don't save the md5 in an annotation if the provided Log4j2 config includes
monitorInterval=as we don't need to trigger a restart of the Solr pods as Log4j2 will reload the config at runtime. If the config does not includemonitorInterval, then we save the md5 hash of the XML in an annotation on the pod spec to trigger a restart as we do for solr.xmlAlso, cleaned up some constant string usage around
solr.xmlandlog4j2.xml