NT: Allow the definition of multiple imagePullSecrets.

[jward-bw]

Currently you can only specify a single imagePullSecret in the ContainerImage, for the SolrImage in SolrCloudSpec. This allows a user to define any number of imagePullSecrets, which is required if initContainers or sidecarContainers need different imagePullSecrets to the SolrImage.

[jward-bw]

Sorry for the multiple failed runs, didn't read the docs enough on building the manifests.

[jward-bw]

Was I supposed to add helm/solr-operator/crds/crds.yaml to my commit? A diff that size smells suspiscious.

[HoustonPutman]

Great start!

Would you mind adding a test for this? And also implement the functionality in the prometheusExporter code as well?

The helm chart change is definitely odd. Are you using the kustomize version specified in hack/install_dependencies.sh?

[jward-bw]

Are you using the kustomize version specified in hack/install_dependencies.sh?

Yep that was the issue, I had an older version installed.

... implement the functionality in the prometheusExporter code as well?

Done!

Would you mind adding a test for this?

Sorry this is my first time writing go code, and I'm not familiar with the testing structure. Where should tests for these changes go?

[HoustonPutman]

Ok the code looks great!

As for the tests, here is some help:

• Where we have been specifying customPodOptions test values.
  So you should be able to add a list of ImagePullSecrets here to use other places in the tests.
• An example test that you could add in the imagePullSecrets
• Where you would actually test that they got added to the Pod

You can do the same thing for the prometheus exporter tests:

• An example prom-exp test that you could add in the imagePullSecrets
• Where you would actually test that they got added to the prom-exp Pod

These tests aren't actually making sure that it runs correctly, it makes sure that the resulting statefulSet object that is created looks as it should. So you just need to make sure that the pod Template in the statefulset has the correct imagePullSecrets section.

[jward-bw]

As for the tests, here is some help:

Thanks so much for the pointers Houston, let me know if I've missed anything.

[HoustonPutman]

Don't think you've missed anything! This looks great, feature & tests. 👌

Thanks for the contribution! Hopefully the first of many 😉