address comments

apache · Jul 15, 2022 · 4889243 · 4889243
1 parent 4dce80b
commit 4889243
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/python/pyspark/sql/tests/test_types.py b/python/pyspark/sql/tests/test_types.py
@@ -1145,6 +1145,7 @@ def test_varchar_type(self):
         self.assertNotEqual(v1, v2)
         v3 = VarcharType(10)
         self.assertEqual(v1, v3)
+        self.assertFalse(v1 is v3)
 
     # regression test for SPARK-10392
     def test_datetype_equal_zero(self):

diff --git a/python/pyspark/sql/types.py b/python/pyspark/sql/types.py
@@ -188,8 +188,7 @@ class VarcharType(AtomicType):
     Parameters
     ----------
     length : int
-    the length limitation. Data writing will fail if the input
-    string exceeds the length limitation.
+        the length limitation.
     """
 
     def __init__(self, length: int):
@@ -1698,7 +1697,7 @@ def verify_acceptable_types(obj: Any) -> None:
                 new_msg("%s can not accept object %r in type %s" % (dataType, obj, type(obj)))
             )
 
-    if isinstance(dataType, StringType) or isinstance(dataType, VarcharType):
+    if isinstance(dataType, (StringType, VarcharType)):
         # StringType and VarcharType can work with any types
         def verify_value(obj: Any) -> None:
             pass