Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SPARK-21603][SQL][FOLLOW-UP] Change the default value of maxLinesPer…
…Function into 4000 ## What changes were proposed in this pull request? This pr changed the default value of `maxLinesPerFunction` into `4000`. In #18810, we had this new option to disable code generation for too long functions and I found this option only affected `Q17` and `Q66` in TPC-DS. But, `Q66` had some performance regression: ``` Q17 w/o #18810, 3224ms --> q17 w/#18810, 2627ms (improvement) Q66 w/o #18810, 1712ms --> q66 w/#18810, 3032ms (regression) ``` To keep the previous performance in TPC-DS, we better set higher value at `maxLinesPerFunction` by default. ## How was this patch tested? Existing tests. Author: Takeshi Yamamuro <[email protected]> Closes #19021 from maropu/SPARK-21603-FOLLOWUP-1.
- Loading branch information