Change Accumulators to private[spark] instead of adding mima exclude …

…to get around false positive in mima tests
apache · Dec 10, 2014 · a581f3f · a581f3f
1 parent b6c2180
commit a581f3f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/core/src/main/scala/org/apache/spark/Accumulators.scala b/core/src/main/scala/org/apache/spark/Accumulators.scala
@@ -279,7 +279,7 @@ object AccumulatorParam {
 
 // TODO: The multi-thread support in accumulators is kind of lame; check
 // if there's a more intuitive way of doing it right
-private object Accumulators {
+private[spark] object Accumulators {
   // TODO: Use soft references? => need to make readObject work properly then
   val originals = Map[Long, Accumulable[_, _]]()
   val localAccums = new ThreadLocal[Map[Long, Accumulable[_, _]]]() {

diff --git a/project/MimaExcludes.scala b/project/MimaExcludes.scala
@@ -53,10 +53,6 @@ object MimaExcludes {
               "org.apache.spark.mllib.linalg.Matrices.randn"),
             ProblemFilters.exclude[MissingMethodProblem](
               "org.apache.spark.mllib.linalg.Matrices.rand")
-          ) ++ Seq(
-            // SPARK-4772
-            ProblemFilters.exclude[IncompatibleResultTypeProblem](
-              "org.apache.spark.Accumulators.localAccums")
           )
 
         case v if v.startsWith("1.2") =>