Skip to content

Commit

Permalink
[HOT-FIX] bypass hive test when parse logical plan to json
Browse files Browse the repository at this point in the history
#10311 introduces some rare, non-deterministic flakiness for hive udf tests, see #10311 (comment)

I can't reproduce it locally, and may need more time to investigate, a quick solution is: bypass hive tests for json serialization.

Author: Wenchen Fan <[email protected]>

Closes #10430 from cloud-fan/hot-fix.

(cherry picked from commit 8543997)
Signed-off-by: Michael Armbrust <[email protected]>
  • Loading branch information
cloud-fan authored and marmbrus committed Jan 13, 2016
1 parent 03e523e commit f71e5cc
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@ abstract class QueryTest extends PlanTest {
case a: ImperativeAggregate => return
}

// bypass hive tests before we fix all corner cases in hive module.
if (this.getClass.getName.startsWith("org.apache.spark.sql.hive")) return

val jsonString = try {
logicalPlan.toJSON
} catch {
Expand All @@ -209,9 +212,6 @@ abstract class QueryTest extends PlanTest {
""".stripMargin, e)
}

// bypass hive tests before we fix all corner cases in hive module.
if (this.getClass.getName.startsWith("org.apache.spark.sql.hive")) return

// scala function is not serializable to JSON, use null to replace them so that we can compare
// the plans later.
val normalized1 = logicalPlan.transformAllExpressions {
Expand Down

0 comments on commit f71e5cc

Please sign in to comment.