Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up of PR #1071 for Java API #1085

Closed
wants to merge 3 commits into from
Closed

Follow up of PR #1071 for Java API #1085

wants to merge 3 commits into from

Conversation

liancheng
Copy link
Contributor

JIRA issue: SPARK-2094

Updated JavaSQLContext and JavaHiveContext similar to what we've done to SQLContext and HiveContext in PR #1071. Added corresponding test case for Spark SQL Java API.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15788/

@marmbrus
Copy link
Contributor

My guess on the test failures is that we are starting up two spark contexts inside of the same JVM, which is not allowed. I had the same problems with the first PR for the Java API, which is why that test is marked ignore. If you can figure it out that would be great. However, I think fixing the idempotence bug for Java DDL commands is important enough to commit this without the additional tests running.

@liancheng
Copy link
Contributor Author

OK, then I'll leave my newly added test cases "ignored". These test cases do pass locally.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15807/

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15817/

@asfgit asfgit closed this in 273afcb Jun 16, 2014
@marmbrus
Copy link
Contributor

Thanks! Merged into master and 1.0.

asfgit pushed a commit that referenced this pull request Jun 16, 2014
@liancheng @rxin
[SQL][SPARK-2094] Follow up of PR #1071 for Java API
9c675de 
Updated `JavaSQLContext` and `JavaHiveContext` similar to what we've done to `SQLContext` and `HiveContext` in PR #1071. Added corresponding test case for Spark SQL Java API.

Author: Cheng Lian <[email protected]>

Closes #1085 from liancheng/spark-2094-java and squashes the following commits:

29b8a51 [Cheng Lian] Avoided instantiating JavaSparkContext & JavaHiveContext to workaround test failure
92bb4fb [Cheng Lian] Marked test cases in JavaHiveQLSuite with "ignore"
22aec97 [Cheng Lian] Follow up of PR #1071 for Java API

(cherry picked from commit 273afcb)
Signed-off-by: Reynold Xin <[email protected]>
@rxin
Copy link
Contributor

rxin commented Jun 16, 2014

FYI This didn't get merged into branch-1.0. I did a manual cherry pick.

@marmbrus
Copy link
Contributor

Oh, sorry. Good catch! I must not have done the last push to apache part...

pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@liancheng @pdeyhim
[SQL][SPARK-2094] Follow up of PR apache#1071 for Java API
4877e05 
Updated `JavaSQLContext` and `JavaHiveContext` similar to what we've done to `SQLContext` and `HiveContext` in PR apache#1071. Added corresponding test case for Spark SQL Java API.

Author: Cheng Lian <[email protected]>

Closes apache#1085 from liancheng/spark-2094-java and squashes the following commits:

29b8a51 [Cheng Lian] Avoided instantiating JavaSparkContext & JavaHiveContext to workaround test failure
92bb4fb [Cheng Lian] Marked test cases in JavaHiveQLSuite with "ignore"
22aec97 [Cheng Lian] Follow up of PR apache#1071 for Java API
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@liancheng @conviva-zz
[SQL][SPARK-2094] Follow up of PR apache#1071 for Java API
6e901bc 
Updated `JavaSQLContext` and `JavaHiveContext` similar to what we've done to `SQLContext` and `HiveContext` in PR apache#1071. Added corresponding test case for Spark SQL Java API.

Author: Cheng Lian <[email protected]>

Closes apache#1085 from liancheng/spark-2094-java and squashes the following commits:

29b8a51 [Cheng Lian] Avoided instantiating JavaSparkContext & JavaHiveContext to workaround test failure
92bb4fb [Cheng Lian] Marked test cases in JavaHiveQLSuite with "ignore"
22aec97 [Cheng Lian] Follow up of PR apache#1071 for Java API
@liancheng liancheng deleted the spark-2094-java branch September 24, 2014 00:10
wangyum pushed a commit that referenced this pull request May 26, 2023
@allenma
[CARMEL-6283] DAGScheduler may stuck when there are too many result t…
280b619 
…ask and result is spilled (#1085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liancheng @AmplabJenkins @marmbrus @rxin