Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-14074][SPARKR] Specify commit sha1 ID when using install_github to install intr package. #11913

Closed
wants to merge 1 commit into from

Conversation

sun-rui
Copy link
Contributor

@sun-rui sun-rui commented Mar 23, 2016

What changes were proposed in this pull request?

In dev/lint-r.R, install_github makes our builds depend on a unstable source. This may cause un-expected test failures and then build break. This PR adds a specified commit sha1 ID to install_github to get a stable source.

How was this patch tested?

dev/lint-r

@SparkQA
Copy link

SparkQA commented Mar 23, 2016

Test build #53909 has finished for PR 11913 at commit 87fa199.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Mar 23, 2016
…b to install intr package.

## What changes were proposed in this pull request?

In dev/lint-r.R, `install_github` makes our builds depend on a unstable source. This may cause un-expected test failures and then build break. This PR adds a specified commit sha1 ID to `install_github` to get a stable source.

## How was this patch tested?
dev/lint-r

Author: Sun Rui <[email protected]>

Closes #11913 from sun-rui/SPARK-14074.

(cherry picked from commit 7d11750)
Signed-off-by: Xiangrui Meng <[email protected]>
@asfgit asfgit closed this in 7d11750 Mar 23, 2016
@mengxr
Copy link
Contributor

mengxr commented Mar 23, 2016

LGTM. Merged into master and branch-1.6. @sun-rui We don't need one PR for each branch if the patch could be merged back to branch-1.6 without conflicts. Could you please close #11914? Thanks!

@sun-rui
Copy link
Contributor Author

sun-rui commented Mar 24, 2016

ok closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants