[SPARK-14786] Remove hive-cli dependency from hive subproject #12551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <configuration> | ||
| <rules> | ||
| <bannedDependencies> | ||
| <excludes combine.children="append"> |
There was a problem hiding this comment.
To verify that this does the correct thing, see
mvn -Phive -pl :spark-hive_2.11 help:effective-pom
|
LGTM pending Jenkins. |
| @@ -110,10 +109,20 @@ private[hive] class HiveClientImpl( | |||
| } | |||
| } | |||
|
|
|||
| def isCliSessionState(state: SessionState): Boolean = { | |||
| var temp: Class[_] = state.getClass | |||
There was a problem hiding this comment.
In a test, this ended up failing with an NPE so I guess that the comment on line 114 / 123 is incorrect :(
|
LGTM |
|
Test build #56455 has finished for PR 12551 at commit
|
|
Test build #56453 has finished for PR 12551 at commit
|
|
Jenkins, retest this please. |
|
Test build #56470 has finished for PR 12551 at commit
|
|
Merging in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hivesubproject currently depends onhive-cliin order to perform a check to see whether aSessionStateis an instance oforg.apache.hadoop.hive.cli.CliSessionState(see #9589). The introduction of thishive-clidependency has caused problems for users whose Hive metastore JAR classpaths don't include thehive-cliclasses (such as in #11495).This patch removes this dependency on
hive-cliand replaces theisInstanceOfcheck by reflection. I added a Maven Enforcer rule to banhive-clifrom thehivesubproject in order to make sure that this dependency is not accidentally reintroduced./cc @rxin @yhuai @adrian-wang @preecet