Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work #14433

Closed
wants to merge 7 commits into from
Closed

[SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work #14433

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2e73994
rename setLogLevel
wangmiao1981 Aug 1, 2016
1a2093a
revert change of rename function name in R; add a case match when ini…
wangmiao1981 Aug 2, 2016
ca4094e
add Enum and API for checking shell type
wangmiao1981 Aug 15, 2016
1b90e97
fix scala style error
wangmiao1981 Aug 15, 2016
89d2b81
revert previous change and add a simple function; manually tested
wangmiao1981 Aug 26, 2016
f10d547
add blankline
wangmiao1981 Aug 26, 2016
ef8887d
simplify the solution
wangmiao1981 Sep 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/scala/org/apache/spark/internal/Logging.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ private[spark] trait Logging {
val replLevel = Option(replLogger.getLevel()).getOrElse(Level.WARN)
if (replLevel != rootLogger.getEffectiveLevel()) {
System.err.printf("Setting default log level to \"%s\".\n", replLevel)
System.err.println("To adjust logging level use sc.setLogLevel(newLevel).")
System.err.println("To adjust logging level use sc.setLogLevel(newLevel). " +
"For SparkR, use setLogLevel(newLevel).")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'd indent this continuation line, I don't think it's worth worrying about. LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this up during the merge

rootLogger.setLevel(replLevel)
}
}
Expand Down