[SPARK-17056][Core] Fix a wrong assert regarding unroll memory in MemoryStore #14642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #63773 has finished for PR 14642 at commit
|
|
Actually I think it might be able to remove this assert... |
|
ping @cloud-fan @JoshRosen since you have modified this file, do you think this change making sense? |
|
This looks correct to me. Let me retest and then I'll merge. |
|
Jenkins, retest this please. |
|
Test build #65999 has finished for PR 14642 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Sep 27, 2016
…oryStore ## What changes were proposed in this pull request? There is an assert in MemoryStore's putIteratorAsValues method which is used to check if unroll memory is not released too much. This assert looks wrong. ## How was this patch tested? Jenkins tests. Author: Liang-Chi Hsieh <[email protected]> Closes #14642 from viirya/fix-unroll-memory. (cherry picked from commit e7bce9e) Signed-off-by: Josh Rosen <[email protected]>
|
@JoshRosen Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There is an assert in MemoryStore's putIteratorAsValues method which is used to check if unroll memory is not released too much. This assert looks wrong.
How was this patch tested?
Jenkins tests.