-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-17095] [Documentation] [Latex and Scala doc do not play nicely] #14688
Conversation
Test build #63920 has finished for PR 14688 at commit
|
The original problem in the JIRA was LaTeX using |
d50990c
to
5cb09f7
Compare
Test build #63922 has finished for PR 14688 at commit
|
5cb09f7
to
7c8fc6f
Compare
Test build #63924 has finished for PR 14688 at commit
|
Ya, this is not the problem I had. Here is an example:
The above will cause the scala doc to barf some weird output at the end because of the terminating
I do not have other instances of this happening in Spark code (that's not to say it doesn't), but it happened on a PR I am currently working on. |
@jagadeesanas2 can you follow up on this to address other instances, including the one you opened the other PR for? |
@srowen I do not find any other instances. Perhaps I send some fixes for Latex string. |
OK I was going to say we would also have to fix the instance @sethah notes above, but looks like that was already fixed or was fixed before committing it. OK this looks fine; I'll verify the rendering. |
Jenkins retest this please |
Test build #64194 has finished for PR 14688 at commit
|
Test build #64192 has finished for PR 14688 at commit
|
Merged to master |
What changes were proposed in this pull request?
In Latex, it is common to find "}}}" when closing several expressions at once. SPARK-16822 added Mathjax to render Latex equations in scaladoc. However, when scala doc sees "}}}" or "{{{" it treats it as a special character for code block. This results in some very strange output.