Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YARN] SPARK-2577: File upload to viewfs is broken due to mount point re... #1483

Closed
wants to merge 1 commit into from
Closed

Conversation

gerashegalov
Copy link
Contributor

Opting to the option 2 defined in SPARK-2577, i.e., retrieve and pass the correct file system object to addResource.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@tgravescs
Copy link
Contributor

Jenkins, test this please

@SparkQA
Copy link

SparkQA commented Jul 18, 2014

QA tests have started for PR 1483. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16833/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 18, 2014

QA results for PR 1483:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16833/consoleFull

@sryza
Copy link
Contributor

sryza commented Jul 18, 2014

@tgravescs do you know whether we need to do anything to fetch tokens for the destination filesystem? Otherwise the change looks good to me.

@tgravescs
Copy link
Contributor

From my understanding when using viewfs: addDelegationTokens is supposed to get tokens for all the underlying filesystems so it should already have a token for it. @gerashegalov did you test this on secure cluster?

@tgravescs
Copy link
Contributor

+1.

@asfgit asfgit closed this in 02e4572 Jul 23, 2014
@gerashegalov
Copy link
Contributor Author

@tgravescs Sorry for coming late. I haven't tested on a secure cluster yet, only on my pseudo-distributed cluster. But since the viewfs implements getChildFileSystems, it should not be an issue.

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
… re...

Opting to the option 2 defined in SPARK-2577, i.e., retrieve and pass the correct file system object to addResource.

Author: Gera Shegalov <[email protected]>

Closes apache#1483 from gerashegalov/master and squashes the following commits:

90c9087 [Gera Shegalov] [YARN] SPARK-2577: File upload to viewfs is broken due to mount point resolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants