[SPARK-17315][SparkR] Kolmogorov-Smirnov test SparkR wrapper #14881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… normal distribution as null hypothesis.
|
Test build #64665 has finished for PR 14881 at commit
|
| #' @details | ||
| #' For more details, see | ||
| #' \href{http://spark.apache.org/docs/latest/mllib-statistics.html#hypothesis-testing}{ | ||
| #' MLlib: Hypothesis Testing}. |
There was a problem hiding this comment.
maybe put this in @Seealso? That seems to be the typical way to add link in our doc
|
Test build #64794 has finished for PR 14881 at commit
|
|
Test build #64865 has finished for PR 14881 at commit
|
|
LGTM |
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Sep 22, 2016
…test summary ## What changes were proposed in this pull request? apache#14881 added Kolmogorov-Smirnov Test wrapper to SparkR. I found that ```print.summary.KSTest``` was implemented inappropriately and result in no effect. Running the following code for KSTest: ```Scala data <- data.frame(test = c(0.1, 0.15, 0.2, 0.3, 0.25, -1, -0.5)) df <- createDataFrame(data) testResult <- spark.kstest(df, "test", "norm") summary(testResult) ``` Before this PR:  After this PR:  The new implementation is similar with [```print.summary.GeneralizedLinearRegressionModel```](https://github.com/apache/spark/blob/master/R/pkg/R/mllib.R#L284) of SparkR and [```print.summary.glm```](https://svn.r-project.org/R/trunk/src/library/stats/R/glm.R) of native R. BTW, I removed the comparison of ```print.summary.KSTest``` in unit test, since it's only wrappers of the summary output which has been checked. Another reason is that these comparison will output summary information to the test console, it will make the test output in a mess. ## How was this patch tested? Existing test. Author: Yanbo Liang <[email protected]> Closes apache#15139 from yanboliang/spark-17315.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR tries to add Kolmogorov-Smirnov Test wrapper to SparkR. This wrapper implementation only supports one sample test against normal distribution.
How was this patch tested?
R unit test.