Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][SQL] Add prettyName for current_database function #15506

Closed
wants to merge 1 commit into from

Conversation

weiqingy
Copy link
Contributor

What changes were proposed in this pull request?

Added a prettyname for current_database function.

How was this patch tested?

Manually.

Before:

scala> sql("select current_database()").show
+-----------------+
|currentdatabase()|
+-----------------+
|          default|
+-----------------+

After:

scala> sql("select current_database()").show
+------------------+
|current_database()|
+------------------+
|           default|
+------------------+

@rxin
Copy link
Contributor

rxin commented Oct 17, 2016

Jenkins, test this please.

@rxin
Copy link
Contributor

rxin commented Oct 17, 2016

LGTM pending Jenkins.

@SparkQA
Copy link

SparkQA commented Oct 17, 2016

Test build #3349 has finished for PR 15506 at commit 6cc9762.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Oct 17, 2016

Thanks - merging in master/branch-2.0.

asfgit pushed a commit that referenced this pull request Oct 17, 2016
## What changes were proposed in this pull request?
Added a `prettyname` for current_database function.

## How was this patch tested?
Manually.

Before:
```
scala> sql("select current_database()").show
+-----------------+
|currentdatabase()|
+-----------------+
|          default|
+-----------------+
```

After:
```
scala> sql("select current_database()").show
+------------------+
|current_database()|
+------------------+
|           default|
+------------------+
```

Author: Weiqing Yang <[email protected]>

Closes #15506 from weiqingy/prettyName.

(cherry picked from commit 56b0f5f)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 56b0f5f Oct 17, 2016
@weiqingy
Copy link
Contributor Author

@rxin Thanks for reviewing this.

robert3005 pushed a commit to palantir/spark that referenced this pull request Nov 1, 2016
## What changes were proposed in this pull request?
Added a `prettyname` for current_database function.

## How was this patch tested?
Manually.

Before:
```
scala> sql("select current_database()").show
+-----------------+
|currentdatabase()|
+-----------------+
|          default|
+-----------------+
```

After:
```
scala> sql("select current_database()").show
+------------------+
|current_database()|
+------------------+
|           default|
+------------------+
```

Author: Weiqing Yang <[email protected]>

Closes apache#15506 from weiqingy/prettyName.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?
Added a `prettyname` for current_database function.

## How was this patch tested?
Manually.

Before:
```
scala> sql("select current_database()").show
+-----------------+
|currentdatabase()|
+-----------------+
|          default|
+-----------------+
```

After:
```
scala> sql("select current_database()").show
+------------------+
|current_database()|
+------------------+
|           default|
+------------------+
```

Author: Weiqing Yang <[email protected]>

Closes apache#15506 from weiqingy/prettyName.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants