Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-18296][SQL] Use consistent naming for expression test suites #15793

Closed
wants to merge 1 commit into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Nov 7, 2016

What changes were proposed in this pull request?

We have an undocumented naming convention to call expression unit tests ExpressionsSuite, and the end-to-end tests FunctionsSuite. It'd be great to make all test suites consistent with this naming convention.

How was this patch tested?

This is a test-only naming change.

@gatorsmile
Copy link
Member

LGTM pending test

@SparkQA
Copy link

SparkQA commented Nov 7, 2016

Test build #68262 has finished for PR 15793 at commit 33f5498.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class BitwiseExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
    • class CollectionExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
    • class MathExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
    • class MiscExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
    • class NullExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
    • case class DoubleData(a: java.lang.Double, b: java.lang.Double)
    • case class NullDoubles(a: java.lang.Double)
    • class MathFunctionsSuite extends QueryTest with SharedSQLContext

@rxin
Copy link
Contributor Author

rxin commented Nov 7, 2016

Thanks - merging in master/branch-2.1. I've disabled the flaky test also (via a commit push).

@asfgit asfgit closed this in 9db06c4 Nov 7, 2016
asfgit pushed a commit that referenced this pull request Nov 7, 2016
## What changes were proposed in this pull request?
We have an undocumented naming convention to call expression unit tests ExpressionsSuite, and the end-to-end tests FunctionsSuite. It'd be great to make all test suites consistent with this naming convention.

## How was this patch tested?
This is a test-only naming change.

Author: Reynold Xin <[email protected]>

Closes #15793 from rxin/SPARK-18296.

(cherry picked from commit 9db06c4)
Signed-off-by: Reynold Xin <[email protected]>
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?
We have an undocumented naming convention to call expression unit tests ExpressionsSuite, and the end-to-end tests FunctionsSuite. It'd be great to make all test suites consistent with this naming convention.

## How was this patch tested?
This is a test-only naming change.

Author: Reynold Xin <[email protected]>

Closes apache#15793 from rxin/SPARK-18296.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants