[SPARK-18632][SQL] AggregateFunction should not implement ImplicitCastInputTypes #16066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rxin |
rxin
reviewed
Nov 29, 2016
| defaultCheck | ||
| } else if (!ignoreNullsExpr.foldable) { | ||
| TypeCheckFailure( | ||
| s"The second argument of Last must be a boolean literal, but got: $ignoreNullsExpr") |
|
LGTM other than that tiny comment. |
|
LGTM |
|
Test build #69349 has finished for PR 16066 at commit
|
|
Test build #69358 has finished for PR 16066 at commit
|
|
Test build #69356 has finished for PR 16066 at commit
|
|
Test build #69367 has finished for PR 16066 at commit
|
|
Merging in master. |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
…tInputTypes ## What changes were proposed in this pull request? `AggregateFunction` currently implements `ImplicitCastInputTypes` (which enables implicit input type casting). There are actually quite a few situations in which we don't need this, or require more control over our input. A recent example is the aggregate for `CountMinSketch` which should only take string, binary or integral types inputs. This PR removes `ImplicitCastInputTypes` from the `AggregateFunction` and makes a case-by-case decision on what kind of input validation we should use. ## How was this patch tested? Refactoring only. Existing tests. Author: Herman van Hovell <[email protected]> Closes apache#16066 from hvanhovell/SPARK-18632.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…tInputTypes ## What changes were proposed in this pull request? `AggregateFunction` currently implements `ImplicitCastInputTypes` (which enables implicit input type casting). There are actually quite a few situations in which we don't need this, or require more control over our input. A recent example is the aggregate for `CountMinSketch` which should only take string, binary or integral types inputs. This PR removes `ImplicitCastInputTypes` from the `AggregateFunction` and makes a case-by-case decision on what kind of input validation we should use. ## How was this patch tested? Refactoring only. Existing tests. Author: Herman van Hovell <[email protected]> Closes apache#16066 from hvanhovell/SPARK-18632.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
AggregateFunctioncurrently implementsImplicitCastInputTypes(which enables implicit input type casting). There are actually quite a few situations in which we don't need this, or require more control over our input. A recent example is the aggregate forCountMinSketchwhich should only take string, binary or integral types inputs.This PR removes
ImplicitCastInputTypesfrom theAggregateFunctionand makes a case-by-case decision on what kind of input validation we should use.How was this patch tested?
Refactoring only. Existing tests.