SPARK-2664. Deal with --conf options in spark-submit that relate to fl...
#1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
| @@ -184,7 +184,7 @@ object SparkSubmit { | |||
| OptionAssigner(args.archives, YARN, CLIENT, sysProp = "spark.yarn.dist.archives"), | |||
|
|
|||
| // Yarn cluster only | |||
| OptionAssigner(args.name, YARN, CLUSTER, clOption = "--name", sysProp = "spark.app.name"), | |||
There was a problem hiding this comment.
Why does this one change?
There was a problem hiding this comment.
The spark.app.name already gets set above with:
OptionAssigner(args.name, ALL_CLUSTER_MGRS, ALL_DEPLOY_MODES, sysProp = "spark.app.name"),
so this is just removing a redundancy.
For reasons that are too boring to be worth going into, this was more thematically affiliated to the rest of the changes before I rebased it. Not strictly related to this patch anymore, so I can fix it separately if you'd like.
There was a problem hiding this comment.
No problem, it's fine to have it here, I was just not sure why it was needed.
|
Looks good Sandy! One small question. |
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
… fl... ...ags Author: Sandy Ryza <[email protected]> Closes apache#1665 from sryza/sandy-spark-2664 and squashes the following commits: 0518c63 [Sandy Ryza] SPARK-2664. Deal with `--conf` options in spark-submit that relate to flags
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Jun 2, 2023
…pache#1665) This PR bumps Boson version to `0.2.16-beta`. Patch list https://github.pie.apple.com/pie/boson/compare/86a94a0...5e1b6aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ags