[SPARK-22985] Fix argument escaping bug in from_utc_timestamp / to_utc_timestamp codegen #20182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #85776 has finished for PR 20182 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jan 8, 2018
…c_timestamp codegen ## What changes were proposed in this pull request? This patch adds additional escaping in `from_utc_timestamp` / `to_utc_timestamp` expression codegen in order to a bug where invalid timezones which contain special characters could cause generated code to fail to compile. ## How was this patch tested? New regression tests in `DateExpressionsSuite`. Author: Josh Rosen <[email protected]> Closes #20182 from JoshRosen/SPARK-22985-fix-utc-timezone-function-escaping-bugs. (cherry picked from commit 71d65a3) Signed-off-by: gatorsmile <[email protected]>
|
Thanks! Merged to master/2.3 |
JoshRosen
deleted the
SPARK-22985-fix-utc-timezone-function-escaping-bugs
branch
cloud-fan
pushed a commit
that referenced
this pull request
Apr 6, 2020
…with escape chars in string parameters ### What changes were proposed in this pull request? In the PR, I propose to add tests to check that code generation doesn't fail if expressions string argument contains escape chars. The PR adds similar tests added by #20182 for `from_utc_timestamp` / `to_utc_timestamp`. ### Why are the changes needed? To prevent regressions in the future. ### Does this PR introduce any user-facing change? No ### How was this patch tested? By running the affected tests Closes #28115 from MaxGekk/tests-arg-escape. Authored-by: Maxim Gekk <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
cloud-fan
pushed a commit
that referenced
this pull request
Apr 6, 2020
…with escape chars in string parameters ### What changes were proposed in this pull request? In the PR, I propose to add tests to check that code generation doesn't fail if expressions string argument contains escape chars. The PR adds similar tests added by #20182 for `from_utc_timestamp` / `to_utc_timestamp`. ### Why are the changes needed? To prevent regressions in the future. ### Does this PR introduce any user-facing change? No ### How was this patch tested? By running the affected tests Closes #28115 from MaxGekk/tests-arg-escape. Authored-by: Maxim Gekk <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 0919852) Signed-off-by: Wenchen Fan <[email protected]>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…with escape chars in string parameters ### What changes were proposed in this pull request? In the PR, I propose to add tests to check that code generation doesn't fail if expressions string argument contains escape chars. The PR adds similar tests added by apache#20182 for `from_utc_timestamp` / `to_utc_timestamp`. ### Why are the changes needed? To prevent regressions in the future. ### Does this PR introduce any user-facing change? No ### How was this patch tested? By running the affected tests Closes apache#28115 from MaxGekk/tests-arg-escape. Authored-by: Maxim Gekk <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch adds additional escaping in
from_utc_timestamp/to_utc_timestampexpression codegen in order to a bug where invalid timezones which contain special characters could cause generated code to fail to compile.How was this patch tested?
New regression tests in
DateExpressionsSuite.