Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-21396][SQL] Fixes MatchError when UDTs are passed through Hive Thriftserver #20385

Closed
wants to merge 2 commits into from
Closed

[SPARK-21396][SQL] Fixes MatchError when UDTs are passed through Hive Thriftserver #20385

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8fb436
Fixes MatchError when UDTs are passed through Hive Thriftserver
atallahhezbor Jan 24, 2018
e05041f
Moves UDT handling to HiveUtils. Adds unit test
atallahhezbor Jan 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...rc/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ private[hive] class SparkExecuteStatementOperation(
to += from.getAs[Timestamp](ordinal)
case BinaryType =>
to += from.getAs[Array[Byte]](ordinal)
case udt: UserDefinedType[_] =>
to += from.get(ordinal).toString
Copy link

@liufengdb liufengdb Jan 24, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible from.get(ordinal) returns null, then a null pointer exception. I think a better way to add this case is by the method HiveUtils.toHiveString, which can potentially be reused and tested.

case _: ArrayType | _: StructType | _: MapType =>
val hiveString = HiveUtils.toHiveString((from.get(ordinal), dataTypes(ordinal)))
to += hiveString
Expand Down