-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-23228][PYSPARK] Add Python Created jsparkSession to JVM's defaultSession #20404
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d9189ad
Add Python Create jsparkSession to JVM's defaultSession
jerryshao eec4386
Address the comment and add UT
jerryshao 0319fa5
Fix test failure and few minor clean up for tests
HyukjinKwon 4ba3aa2
Address the failed UT
jerryshao dd1c991
Merge pull request #11 from HyukjinKwon/test-cleanup
jerryshao ec94c05
Merge remote-tracking branch 'jerryshao-spark/SPARK-23228' into SPARK…
jerryshao d9f77ea
Fix python style
jerryshao 1ed62ef
Fix Python Style issue
jerryshao e5f4b58
Address the comments
jerryshao cc4b851
Simplify the code
jerryshao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this change at 4ba3aa2 is enough to fix the previous test failure (
ERROR: test_sparksession_with_stopped_sparkcontext (pyspark.sql.tests.SQLTests2)
) and we can revert movingself._jvm.SparkSession.clearDefaultSession()
toSparkContext.stop()
at0319fa5 now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. I will do it.