Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSuiteBase twice #20412

Closed
wants to merge 1 commit into from
Closed

[SPARK-23242][SS][Tests]Don't run tests in KafkaSourceSuiteBase twice #20412

wants to merge 1 commit into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Jan 26, 2018

What changes were proposed in this pull request?

KafkaSourceSuiteBase should be abstract class, otherwise KafkaSourceSuiteBase will also run.

How was this patch tested?

Jenkins

@tdas
Copy link
Contributor

tdas commented Jan 26, 2018

LGTM. My bad, I should caught this in the original PR that @jose-torres made.

@SparkQA
Copy link

SparkQA commented Jan 26, 2018

Test build #86724 has finished for PR 20412 at commit bd124b3.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • abstract class KafkaSourceSuiteBase extends KafkaSourceTest

@zsxwing
Copy link
Member Author

zsxwing commented Jan 26, 2018

retest this please

dongjoon-hyun
dongjoon-hyun approved these changes Jan 27, 2018
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@SparkQA
Copy link

SparkQA commented Jan 27, 2018

Test build #4078 has finished for PR 20412 at commit bd124b3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • abstract class KafkaSourceSuiteBase extends KafkaSourceTest

@zsxwing
Copy link
Member Author

zsxwing commented Jan 27, 2018

Thanks! Merging to master and 2.3.

asfgit pushed a commit that referenced this pull request Jan 27, 2018
@zsxwing
[SPARK-23242][SS][TESTS] Don't run tests in KafkaSourceSuiteBase twice
7aaf23c 
## What changes were proposed in this pull request?

KafkaSourceSuiteBase should be abstract class, otherwise KafkaSourceSuiteBase will also run.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes #20412 from zsxwing/SPARK-23242.

(cherry picked from commit 0737449)
Signed-off-by: Shixiong Zhu <[email protected]>
ghost pushed a commit to dbtsai/spark that referenced this pull request Jan 27, 2018
@zsxwing
[SPARK-23242][SS][TESTS] Don't run tests in KafkaSourceSuiteBase twice
0737449 
## What changes were proposed in this pull request?

KafkaSourceSuiteBase should be abstract class, otherwise KafkaSourceSuiteBase will also run.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes apache#20412 from zsxwing/SPARK-23242.
@zsxwing zsxwing closed this Jan 27, 2018
@zsxwing zsxwing deleted the SPARK-23242 branch January 27, 2018 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zsxwing @tdas @SparkQA @dongjoon-hyun