-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR] Fix typos in dev/* scripts. #20436
Conversation
@@ -60,9 +60,9 @@ export "PYLINT_HOME=$PYTHONPATH" | |||
export "PATH=$PYTHONPATH:$PATH" | |||
|
|||
# There is no need to write this output to a file | |||
#+ first, but we do so so that the check status can | |||
#+ be output before the report, like with the | |||
#+ scalastyle and RAT checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this wasn't from SPARK-23174 tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm .. seems this indicates line continuation and intentional .. ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that so? We have 100 character limit on a single line according to the style guide. Maybe all 4 lines could be rearranged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm .. @nchammas, some of these seem added by you a long ago. Could you take a look for this one please? I think I am not aware of this. Wonder if we can just remove those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The #+
convention is something I picked up from the Linux Documentation Project, if that's what you're referring to. You can safely do away with it and just have the #
.
It was a "phase". I'm over it now... 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thank you so much.
ok to test |
I would rather suggest to fix these together in the followup already open, 20432 or find out more typos while we are here. |
@HyukjinKwon Let me go ahead and check all the scripts for similar instances or typos. |
@ashashwat, thanks. Let's update the PR title to something like .. |
Test build #86816 has finished for PR 20436 at commit
|
Test build #86821 has finished for PR 20436 at commit
|
Test build #86828 has finished for PR 20436 at commit
|
Merged to master. |
What changes were proposed in this pull request?
Consistency in style, grammar and removal of extraneous characters.
How was this patch tested?
Manually as this is a doc change.