Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-23261][PYSPARK][BACKPORT-2.3] Rename Pandas UDFs #20439

Closed
wants to merge 1 commit into from

Conversation

gatorsmile
Copy link
Member

@gatorsmile gatorsmile commented Jan 30, 2018

This PR is to backport #20428 to Spark 2.3 without adding the changes regarding GROUPED AGG PANDAS UDF


What changes were proposed in this pull request?

Rename the public APIs and names of pandas udfs.

  • PANDAS SCALAR UDF -> SCALAR PANDAS UDF
  • PANDAS GROUP MAP UDF -> GROUPED MAP PANDAS UDF

How was this patch tested?

The existing tests

Rename the public APIs and names of pandas udfs.

- `PANDAS SCALAR UDF` -> `SCALAR PANDAS UDF`
- `PANDAS GROUP MAP UDF` -> `GROUPED MAP PANDAS UDF`
- `PANDAS GROUP AGG UDF` -> `GROUPED AGG PANDAS UDF`

The existing tests

Author: gatorsmile <[email protected]>

Closes apache#20428 from gatorsmile/renamePandasUDFs.
@gatorsmile
Copy link
Member Author

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

Copy link
Member

@BryanCutler BryanCutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Jan 30, 2018

Test build #86841 has finished for PR 20439 at commit 1a70ae1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Jan 31, 2018
This PR is to backport #20428 to Spark 2.3 without adding the changes regarding `GROUPED AGG PANDAS UDF`

---

## What changes were proposed in this pull request?
Rename the public APIs and names of pandas udfs.

- `PANDAS SCALAR UDF` -> `SCALAR PANDAS UDF`
- `PANDAS GROUP MAP UDF` -> `GROUPED MAP PANDAS UDF`

## How was this patch tested?
The existing tests

Author: gatorsmile <[email protected]>

Closes #20439 from gatorsmile/backport2.3.
@gatorsmile
Copy link
Member Author

Thanks! Merged to 2.3.

@gatorsmile gatorsmile closed this Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants