[SPARK-27823][CORE] Add an abstraction layer for resource handling #24821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #106282 has finished for PR 24821 at commit
|
|
Test build #106283 has finished for PR 24821 at commit
|
|
Retest this please. |
|
Test build #106290 has finished for PR 24821 at commit
|
|
looking at test failures to see if I can reproduce locally |
|
Test build #106351 has finished for PR 24821 at commit
|
|
making a pass |
|
@tgravescs I will do some refactoring and send a PR to you. |
|
@mengxr please just put up a PR |
|
will do |
kiku-jw
pushed a commit
to kiku-jw/spark
that referenced
this pull request
Jun 26, 2019
## What changes were proposed in this pull request? Continue the work from apache#24821. Refactor resource handling code to make the code more readable. Major changes: * Moved resource-related classes to `spark.resource` from `spark`. * Added ResourceUtils and helper classes so we don't need to directly deal with Spark conf. * ResourceID: resource identifier and it provides conf keys * ResourceRequest/Allocation: abstraction for requested and allocated resources * Added `TestResourceIDs` to reference commonly used resource IDs in tests like `spark.executor.resource.gpu`. cc: tgravescs jiangxb1987 Ngone51 ## How was this patch tested? Unit tests for added utils and existing unit tests. Closes apache#24856 from mengxr/SPARK-27823. Lead-authored-by: Xiangrui Meng <[email protected]> Co-authored-by: Thomas Graves <[email protected]> Signed-off-by: Xingbo Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add an abstraction layer for the Resource layer stuff to make it more readable.
I think the only actual behavioral change here is that now you can specify both a resourceFileOpt and the discovery script for different resources and it will join them together. Previously it only allowed one or the other option to be used. I did also add in one more warning for the user when the resource configurations will waste resources.
How was this patch tested?
Unit tests and ran on local cluster, yarn