-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-27369][CORE] Setup resources when Standalone Worker starts up #24841
Closed
Closed
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ceaaa90
setup worker resources when it starts up
Ngone51 d60f37f
document
Ngone51 44280fa
address comment
Ngone51 a1cd955
rebase
Ngone51 0960bcf
revert unneeded change
Ngone51 ba62e35
ResourceInformation -> ResourceAllocation
Ngone51 41a70bd
address nit
Ngone51 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,17 @@ package org.apache.spark.internal.config | |
import java.util.concurrent.TimeUnit | ||
|
||
private[spark] object Worker { | ||
val SPARK_WORKER_PREFIX = "spark.worker" | ||
|
||
val SPARK_WORKER_RESOURCE_FILE = | ||
ConfigBuilder("spark.worker.resourcesFile") | ||
.internal() | ||
.doc("Path to a file containing the resources allocated to the worker. " + | ||
"The file should be formatted as a JSON array of ResourceInformation objects. " + | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this is true anymore, I think the json has to be formatted like a ResourceAllocation There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for catching this. |
||
"Only used internally in standalone mode.") | ||
.stringConf | ||
.createOptional | ||
|
||
val WORKER_TIMEOUT = ConfigBuilder("spark.worker.timeout") | ||
.longConf | ||
.createWithDefault(60) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I would prefer
import org.apache.spark.resource.ResourceUtils._
.