Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods #27181

Closed
wants to merge 3 commits into from
Closed

[SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods #27181

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
180a592
Remove OneVsRestModel.setClassifier
zero323 Jan 12, 2020
a727e3f
Remove setLabelCol and setWeightCol methods
zero323 Jan 12, 2020
82367a3
Use _set to set labelCol
zero323 Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions python/pyspark/ml/classification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2637,13 +2637,6 @@ class OneVsRestModel(Model, _OneVsRestParams, JavaMLReadable, JavaMLWritable):
.. versionadded:: 2.0.0
"""

@since("2.0.0")
def setClassifier(self, value):
"""
Sets the value of :py:attr:`classifier`.
"""
return self._set(classifier=value)

def setFeaturesCol(self, value):
"""
Sets the value of :py:attr:`featuresCol`.
Expand All @@ -2662,18 +2655,6 @@ def setRawPredictionCol(self, value):
"""
return self._set(rawPredictionCol=value)

def setLabelCol(self, value):
"""
Sets the value of :py:attr:`labelCol`.
"""
return self._set(labelCol=value)

def setWeightCol(self, value):
"""
Sets the value of :py:attr:`weightCol`.
"""
return self._set(weightCol=value)

def __init__(self, models):
super(OneVsRestModel, self).__init__()
self.models = models
Expand Down Expand Up @@ -2773,8 +2754,9 @@ def _from_java(cls, java_stage):
predictionCol = java_stage.getPredictionCol()
classifier = JavaParams._from_java(java_stage.getClassifier())
models = [JavaParams._from_java(model) for model in java_stage.models()]
py_stage = cls(models=models).setPredictionCol(predictionCol).setLabelCol(labelCol)\
py_stage = cls(models=models).setPredictionCol(predictionCol)\
.setFeaturesCol(featuresCol)
py_stage._set(labelCol=labelCol)
py_stage._set(classifier=classifier)
py_stage._resetUid(java_stage.uid())
return py_stage
Expand Down