[SPARK-29947][SQL][FOLLOWUP] Fix table lookup cache #27341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #117304 has finished for PR 27341 at commit
|
| import org.apache.spark.sql.internal.SQLConf | ||
| import org.apache.spark.sql.types._ | ||
|
|
||
| class TableLookupCacheSuite extends AnalysisTest with Matchers { |
There was a problem hiding this comment.
Thank you for adding this test suite, @cloud-fan .
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
+1, LGTM. The test suite is very useful for validation. Thanks.
Merged to master.
All test passed. The R failure is a known incoming feasibility check flakiness. cc @viirya
* checking CRAN incoming feasibility ...Error in .check_package_CRAN_incoming(pkgdir) :
dims [product 26] do not match the length of object [0]
|
hmm, is CRAN failure still there now? I got their reply that was fixed. This failure looks like 5hrs ago. If there is new failure, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix a bug in #26589 , to make this feature work.
Why are the changes needed?
This feature doesn't work actually.
Does this PR introduce any user-facing change?
no
How was this patch tested?
new test