[SPARK-32458][SQL][TESTS] Fix incorrectly sized row value reads. #29258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use getInt to fetch 32 bit values and getLong to fetch 64 bit values. The mismatched sizes caused test failures on big-endian systems.
|
ok to test |
HyukjinKwon
approved these changes
Jul 27, 2020
|
Test build #126649 has finished for PR 29258 at commit
|
srowen
approved these changes
Jul 28, 2020
dongjoon-hyun
approved these changes
Jul 28, 2020
|
You are added to the Apache Spark contributor group and SPARK-32458 is assigned to you. Welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Updates to tests to use correctly sized
getIntorgetLongcalls.Why are the changes needed?
The reads were incorrectly sized (i.e.
putLongpaired withgetIntandputIntpaired withgetLong). This causes test failures on big-endian systems.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tests were run on a big-endian system (s390x). This change is unlikely to have any practical effect on little-endian systems.