Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-34436][SQL] DPP support LIKE ANY/ALL expression #31563

Closed
wants to merge 2 commits into from
+21 −0
Closed

[SPARK-34436][SQL] DPP support LIKE ANY/ALL expression #31563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c174dd7
SPARK-34436: DPP support LIKE ANY/ALL expression
wangyum Feb 14, 2021
a1592d3
Update DynamicPartitionPruningSuite.scala
wangyum Feb 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ object PartitionPruning extends Rule[LogicalPlan] with PredicateHelper {
case _: BinaryComparison => true
case _: In | _: InSet => true
case _: StringPredicate => true
case _: MultiLikeBase => true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is a regression in 3.1 because we introduced this MultiLikeBase?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. we will simplify MultiLikeBase by SPARK-33938.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fixed version of SPARK-33938 is 3.1.1, so it's a 3.1 regression?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. I forget 3.1.0.

case _ => false
}

Expand Down
20 changes: 20 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1388,6 +1388,26 @@ abstract class DynamicPartitionPruningSuiteBase
checkAnswer(df, Nil)
}
}

test("SPARK-34436: DPP support LIKE ANY/ALL expression") {
withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") {
val df = sql(
"""
|SELECT date_id, product_id FROM fact_sk f
|JOIN dim_store s
|ON f.store_id = s.store_id WHERE s.country LIKE ANY ('%D%E%', '%A%B%')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding more tests for LIKE ALL, NOT LIKE ANY, and NOT LIKE ALL?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion. It's caused by the multi like optimization and any of these 3 can trigger this bug.

""".stripMargin)

checkPartitionPruningPredicate(df, false, true)

checkAnswer(df,
Row(1030, 2) ::
Row(1040, 2) ::
Row(1050, 2) ::
Row(1060, 2) :: Nil
)
}
}
}

class DynamicPartitionPruningSuiteAEOff extends DynamicPartitionPruningSuiteBase {
Expand Down